search

codegouvfr / react-dsfr

🇫🇷 The French Government Design system React toolkit
https://react-dsfr.codegouv.studio
MIT License
406 stars 51 forks source link

Open partners logos links in a new tab (Footer) #205

Closed slafayIGN closed 9 months ago

slafayIGN commented 10 months ago

The Footer component allows only 3 parameters for a partnerLogo :

This doesn't give the possibility to open href in a new tab. This would require : target (_blank), title (which has to bear a " - open in a new window" suffix) and rel (e.g. noreferrer).

Possible fixes could be :

  1. Adding target, title and rel properties
  2. replacing href by a link object (with all linkProps available), this would be a breaking change
  3. make opening in a new tab the default and only possibility by changing the returned footer structure
slafayIGN commented 9 months ago

I proposed PR #209 implementing the 3rd fix.

slafayIGN commented 9 months ago

🚀 Included in release v0.78.7 and up