search

codegouvfr / react-dsfr

🇫🇷 The French Government Design system React toolkit
https://react-dsfr.codegouv.studio
MIT License
406 stars 51 forks source link

Update consentManagement stories #230

Closed enguerranws closed 6 months ago

enguerranws commented 7 months ago

I'm currently installing the consentManagement on IF.

First, many thanks to those who worked on this, it took 5 minutes to install and make it work with our cookies (and well, writing the labels took the most of the time).

The stories seem out of date, the Placeholder component doesn't seem to be defined in the project.

I can clean it up in the next few days.

garronej commented 7 months ago

@enguerranws

Thank you dude! Took me a bunch of time and effort to come up with this. @lsagetlethias worked a lot as well.
You care correct regarding the <Placeholder /> it's not that it's out of date, it's just that I got a bit discouraged and I didn't go the extra miles of implementing it.
You can either remove it from the story or even better, add the component for it!

enguerranws commented 7 months ago

@garronej Sure, I didn't understand what was this Placeholder component, but I just checked the docs and it's clear now.

I'll take a look at this as soon as possible.

enguerranws commented 6 months ago

Closed by https://github.com/codegouvfr/react-dsfr/pull/232