codegouvfr / react-dsfr

🇫🇷 The Frech Government Design system React toolkit
https://react-dsfr.codegouv.studio
MIT License
403 stars 49 forks source link

Feature / add consentManager Placeholder component #232

Closed enguerranws closed 6 months ago

enguerranws commented 6 months ago

I added the consentManager's Placeholder component based on the example given on the stories.

While adding the consent manager on our project, the CI failed on accessbility tests (aXe). I took the liberty to add titleAs so we have not to stick to arbitrary H levels on the DSFR examples (which are, depending on the context, accessibility issues):

Still discussing on it on Mattermost: https://mattermost.incubateur.net/betagouv/threads/jnzhstsadbdjib9ithqhotte7h

enguerranws commented 6 months ago

Still having issues:

I think I'll remove all semantic / accessbility related things in another PR.

garronej commented 6 months ago

Let me know when you want me to review it!
And thanks a lot fot this!

enguerranws commented 6 months ago

@garronej feel free to review it :)

garronej commented 6 months ago

Looks great, thanks a lot!

garronej commented 6 months ago

<3