codegouvfr / sill

The code of : https://code.gouv.fr/sill
https://code.gouv.fr/sill
11 stars 7 forks source link

service provider tab #78

Closed JeromeBu closed 9 months ago

JeromeBu commented 11 months ago
garronej commented 11 months ago

@JeromeBu I'll be very happy to do a little peer programing session with you where we would merge this together. Just let me know. I'm available when you are.

JeromeBu commented 11 months ago

Fixes #52

garronej commented 11 months ago

I appreciate the effort that has gone into this implementation, however, I have some suggestions that could enhance its efficiency and user experience. Currently, the approach of downloading service providers for all software at once seems suboptimal. A more dynamic solution, where the API provides only the necessary information on demand, would be beneficial.

One concern is that the current setup results in the page load being entirely dependent on the downloading of these providers. This could be addressed by implementing lazy loading of the providers, specifically on the detail page where they are actually needed. Such a change would help in reducing the initial load time of the App and improve the user experience significantly.

Ideally, a getSoftwareServiceProvider endpoint could be introduced in the API, or the necessary information could be integrated into the getSoftwares function.

Additionally, regarding the consolidation of the provider data, I believe it would be more efficient to incorporate this into the sill's compileData function, rather than having it as a separate standalone project. This integration could streamline the process and maintain consistency within the project.

Thank you for your work on this, and I look forward to seeing how these suggestions might be integrated to further enhance the project.