Closed Haegin closed 8 years ago
:+1: but the build seems to fail on AS 4+, could you look at it?
@oriolgual Sorry about that. I've now fixed up that problem and the tests pass on 3.2, 4.0 and 4.2.
Just one last thing, can you squash the commits into a single one? :angel:
Sure thing. Squashed!
I can see the build has now failed on 1.9.3 and ActiveRecord 4.2. I'm not sure why but I'm trying to get things set up locally so I can test this particular combination. It's strange that it was successful in the unsquashed commit though.
Seems it was an error with Travis, fixed now!
Rather than requiring the extensions in the tests, we can just require what we need in the place we need it.
New tests aren't needed - the original tests were passing because necessary dependencies were loaded in the test_helper rather than in the runtime code.
Without this you can't use the date_validator gem unless you're already loading ActiveSupport in your project.