codegram / date_validator

A simple, ORM agnostic, Ruby >=2.2 compatible date validator for Rails, based on ActiveModel.
http://thoughts.codegram.com/date-validation-with-rails-3
MIT License
495 stars 82 forks source link

Fix I18n conflict and add Arabic translation #77

Closed MortadaAK closed 5 years ago

MortadaAK commented 7 years ago

Fix the conflict by adding prefix (date_) in the local files.

Add Arabic translation

mrcasals commented 7 years ago

@MortadaAK thanks for your PR! What is this conflicting with? :)

MortadaAK commented 7 years ago

The conflict happens with when using validates_numericality_of on equal_to You are overwriting the error message by using %{date} instead of %{count}

MortadaAK commented 7 years ago

It will fix the problem in issue #76

mrcasals commented 7 years ago

@MortadaAK oh thanks, I didn't see that issue! I'll ping @oriolgual and see if we can merge this and publish a new release :) Maybe a v1.0.0 would be good here...

patleb commented 6 years ago

Any chances for the merge to happen?