Future should not marschal when it contains exceptions

codegram / futuroscope

Yet another Futures implementation in Ruby

MIT License

209 stars 13 forks source link

Future should not marschal when it contains exceptions #18

Closed stephan-roolvink closed 10 years ago

stephan-roolvink commented 10 years ago

The reason for this fix is that, when you cache a future that produces an exception you are storing an exception state. Which in my opinion does not make sence.

josepjaume commented 10 years ago

Sorry, I forgot about this! It makes a lot of sense. Merging and releasing!

ggPeti commented 10 years ago

I don't see why the whole body of __getobj__ needs to be factored out to another method. Why not just call __getobj__ from marshal_dump?

Edit: never mind, got it.