search

codegram / rack-webconsole

Rack-based interactive console (à la Rails console) for your web application's front-end
http://codegram.github.com/rack-webconsole
248 stars 50 forks source link

change key to something different which requires only one key press #14

Closed gucki closed 13 years ago

gucki commented 13 years ago

I dont really think that using the key is a good idea. At least for me I always have to to two key presses ( and then any other key, like space bar).

I think it should be changed to some other key which is also almost never used but requires only a single keypress. Any ideas? :)

oriolgual commented 13 years ago

Do you think you could make a patch with an option where you can set your custom key?

rogerleite commented 13 years ago

Hi. I'm working on it. You can see at https://github.com/rogerleite/rack-webconsole Pull request in queue. :D

rogerleite commented 13 years ago

gucki, is ok to close this issue?

gucki commented 13 years ago

Sorry, I misread the available pull requests. I'd keep this issue open till the pull request is actually here.. :)

oriolgual commented 13 years ago

Actually is OK, this was implemented by @rogerleite

gucki commented 13 years ago

Omg, didn't see it's been merged already.