search

codegram / rack-webconsole

Rack-based interactive console (à la Rails console) for your web application's front-end
http://codegram.github.com/rack-webconsole
248 stars 50 forks source link

Catch SyntaxErrors #39

Closed ravinggenius closed 12 years ago

ravinggenius commented 13 years ago

I add a failing spec, then got it to pass. Let me know if I need to be more thorough.

ravinggenius commented 13 years ago

Only commit 5fd13a4 should be included in this pull request. Not sure why the others are there.

josepjaume commented 13 years ago

Hi! I've been trying to merge your commit but it conflicts with latest master changes. Could you try to rebase your branch?

Thank you very much!

ravinggenius commented 13 years ago

I have a merge conflict as well. Which commits where you trying to merge? Just 5fd13a4 or everything in my master branch?

txus commented 12 years ago

I've manually cherry-picked your spec, because using the Ripl shell theoretically catches Syntax Errors (that's on master already). Nevertheless it won't pass because it actually doesn't (the hash[:result] is nil instead of "Error: whatever"). Maybe @cldwalker knows about it?

txus commented 12 years ago

As an update, I've tried to pass the Ripl specs and apparently catching SyntaxErrors and LoadErrors fails on the latest version (0.6.1).

cldwalker commented 12 years ago

@ravinggenius Are you working off of a stale version of rack-webconsole? I don't see any ripl code in your repo

ravinggenius commented 12 years ago

I haven't looked at this since September, so my repository is likely completely stale. I'll check my issues and pull requests to see if any of them still make sense.