Minor release for run randomization feature

codegram / spinach

Spinach is a BDD framework on top of Gherkin.

codegram.github.com/spinach

MIT License

580 stars 69 forks source link

Minor release for run randomization feature #206

Closed yarmiganosca closed 6 years ago

yarmiganosca commented 6 years ago

As mentioned in #196, here's a version bump PR. I'm not sure if any other tasks need doing before a release, but if you tell me what they are, I'll be happy to do them!

coveralls commented 6 years ago

Coverage increased (+2.05%) to 94.207% when pulling dd09c2f69fb7fc2d83f720a2807832ca0c3efc45 on yarmiganosca:version-0-11-0 into 09ba608a2e9eccad0f0c92ace33aa550a199014a on codegram:master.

yarmiganosca commented 6 years ago

I still have no idea what's wrong with the Travis runs for JRuby.

ywen commented 6 years ago

I am happy to look into jRuby failure tonight or sometime tomorrow

ywen commented 6 years ago

@yarmiganosca It appears that simplecov isn't working well with jRuby. Maybe you can consider doing the as suggested in https://stackoverflow.com/a/45873770/198616 to get more detailed info on why?

ywen commented 6 years ago

Under jruby 9.1.2 I can run bundle exec rake locally with an exit 1 as well. So I can debug locally. Will do so when I am free next week

yarmiganosca commented 6 years ago

Ok, I think I figured it out. JRuby seems to have a problem with this syntax (which I didn't know was a thing), and guess what? Capybara uses that syntax in exactly the file we have problems with: https://github.com/teamcapybara/capybara/blob/master/lib/capybara/node/actions.rb#L310-L331

Given that capybara is only a development dependency for spinach, using a newer version of JRuby which can parse heredocs with quotes (and is therefore compatible with capybara) doesn't actually impact our users.

ywen commented 6 years ago

lol. oh wow nice finding! Yeah I agree we can update ruby version