codegram / vim-codereview

GItHub Pull Request-based Code Reviews
239 stars 18 forks source link

I'm betting this is due to my setup, but maybe i missed something? #1

Closed jjasghar closed 10 years ago

jjasghar commented 10 years ago
Error detected while processing /Users/jasghar/Dropbox/configs/vim/bundle/vim-codereview/autoload/codereview.vim:
line    3:
LoadError: /Users/jasghar/Dropbox/configs/vim/bundle/vim-codereview/lib/code_review.rb:2:in `require': no such file to load -- json
LoadError: /Users/jasghar/Dropbox/configs/vim/bundle/vim-codereview/lib/code_review.rb:2:in `require': no such file to load -- json
E117: Unknown function: codereview#Review
Press ENTER or type command to continue

I have +ruby/dyn on :version and i have curl; and i got Vundle installed.

This looks like it can do something rubyish?

Any help would be greatly appreciated!

dagingaa commented 10 years ago

Same here. I also get initial errors when starting vim:

Error detected while processing function pathogen#helptags:
line    4:
E154: Duplicate tag "codereview" in file /Users/dagingaa/.vim/bundle/vim-codereview/doc/codereview.txt
E154: Duplicate tag "codereview" in file /Users/dagingaa/.vim/bundle/vim-codereview/doc/codereview.txt
E154: Duplicate tag "patchreview" in file /Users/dagingaa/.vim/bundle/vim-codereview/doc/codereview.txt
Press ENTER or type command to continue

I tried running gem install json but no luck.

prognostikos commented 10 years ago

I had a similar issue that I fixed by recompiling my homebrew macvim. I hadn't done so after upgrading to 10.9.

txus commented 10 years ago

It uses whatever Ruby was there when you compiled Vim -- so probably the system Ruby. In my case, I changed to Ruby 2.0 and recompiled Vim, and everything was good. :)

jjasghar commented 10 years ago

Yep, I rebuilt MacVim and it works like a charm. I'm closing this, and thanks for all the comments and help!