codegreencreative / laravel-samlidp

Laravel SAML IdP
MIT License
232 stars 84 forks source link

Jetstream user delete account resulting in redirect error #103

Closed ChadwickLloyd closed 1 year ago

ChadwickLloyd commented 2 years ago

Hi,

Im using laravel 8 with jetstream, and while doing testing have come across an issue.

The user is successfully deleted, however when saml logout is called an error occurs.

I am being displayed this issue:

ErrorException Object of class Livewire\Redirector could not be converted to int

which is starting here (vendor/codegreencreative/laravel-samlidp/src/Listeners/SamlLogout.php):

`public function handle(Logout $event)

{

    // Make sure we are not in the process of SLO when handling the redirect

    if (in_array($event->guard, config('samlidp.guards')) && null === session('saml.slo')) {

        abort(redirect('saml/logout'), 200);

    }

}`

Im not entirely sure, but I believe its because the call parameters arent aligned.

It should be: app()->abort($code, $message, $headers);

Has anyone come across a similar issue / have any suggestions for resolving this?

Cheers.

upwebdesign commented 1 year ago

@ChadwickLloyd did you ever figure this out? I don't belive the abort helper parameters are reversed.