search

codeguy / php-the-right-way

An easy-to-read, quick reference for PHP best practices, accepted coding standards, and links to authoritative tutorials around the Web
https://www.phptherightway.com
Other
9.07k stars 3.24k forks source link

Dwoo library removed from the list of Libraries #921

Closed igorradovanov closed 2 years ago

igorradovanov commented 2 years ago

Dwoo library has been removed due that Dwoo project has been discounted and the link within the PHP The Right Way documentation links to a gambling website. Issue #919

Xymph commented 2 years ago

Although now unmaintained and discontinued, there still is an archived GH repository: https://github.com/dwoo-project/dwoo So perhaps instead of deleting the entry altogether, an update of its link suffices?

matthewtrask commented 2 years ago

if it is unmaintained I think removing it versus leaving it with a note is ideal so that way we dont encourage others to possibly use it. I will leave this open for a bit for any other conversation/opinions.

codeguy commented 2 years ago

I agree with @matthewtrask. Doesn't need to be included if it's discontinued and no longer used or recommended.

Xymph commented 2 years ago

Fine. But shouldn't the PR have been merged before closing, then? As that commit indeed removes it from the list.

codeguy commented 2 years ago

@Xymph Indeed you are correct. Re-opened and merged. Thanks!