search

codeguy / php-the-right-way

An easy-to-read, quick reference for PHP best practices, accepted coding standards, and links to authoritative tutorials around the Web
https://www.phptherightway.com
Other
9.04k stars 3.24k forks source link

Remove 404 register globals PHP link #957

Closed petk closed 1 year ago

petk commented 1 year ago

The PHP manual page about register_globals directive has been removed in the PHP manual. https://github.com/php/doc-en/pull/327

Xymph commented 1 year ago

Thanks.

jrfnl commented 1 year ago

Sorry for butting in, but you basically now have a link which no longer links to anything in the markdown. If needs be - the previous link could be replaced with a link to the same page in the PHP 5 documentation archive hosted by Zend: https://php-legacy-docs.zend.com/manual/php5/en/index

jrfnl commented 1 year ago

On a loosely related note: I could set up some CI/a GH Actions workflow which does some basic checks on the markdown for style and correctness, including a broken link check and such.

If there is interest, please create an issue for it and feel free to assign me to it. I probably won't get to it before March, but I have set up similar workflows for some other repos, so it would largely be a case of copy/pasting those and then making some tweaks and doing some basic clean up.

Xymph commented 1 year ago

Sorry for butting in, but you basically now have a link which no longer links to anything in the markdown.

Maybe I'm blind but I don't see which unlinked link you're referring to. Please point it out.

As for workflow improvements, I know very little about that and it is best discussed with the repo owner, @codeguy .

jrfnl commented 1 year ago

Sorry for butting in, but you basically now have a link which no longer links to anything in the markdown.

Maybe I'm blind but I don't see which unlinked link you're referring to. Please point it out.

You are 100% correct, I mistook the *[]() for a []: link reference. My bad for looking things over too quickly.

As for workflow improvements, I know very little about that and it is best discussed with the repo owner, @codeguy .

As I said, if there's interest, I'll happily work up something. So @codeguy, let me know.

petk commented 1 year ago

Yes, that was just a link in the markdown used only on this place. Not a reference. Otherwise, I'm here thinking more from a reader point of view. Those that will be looking for what are these register globals can still find some info on this page otherwise it will be really rare actually for new PHP developers because that is prehistoric feature. It would be almost like for today's PHP developers reading about PHP 3. That's why.