Use Path in the Scanner API

codehaus-plexus / plexus-utils

Plexus Utils

https://codehaus-plexus.github.io/plexus-utils/

Apache License 2.0

35 stars 37 forks source link

Use Path in the Scanner API #226

Open laeubi opened 1 year ago

laeubi commented 1 year ago

This would be a minimal change to move the API of Scanner to the Path API

This could be some kind of minimal change that could be merged as base for larger changes like:

https://github.com/codehaus-plexus/plexus-utils/pull/225

laeubi commented 1 year ago

@olamy could this be a first step?

kwin commented 1 year ago

Also look at https://github.com/apache/maven-shared-utils/pull/54. IMHO we should only implement in one library....

laeubi commented 1 year ago

Also look at apache/maven-shared-utils#54. IMHO we should only implement in one library....

The most notable thing I see is that it is two years old now and no progress at all...

gnodet commented 1 year ago

I'm a bit skeptical about breaking the API and replacing the return type of the getBasedir(). A less problematic approach would be to provide a different method which would return a Path instead, or a new interface if we want to avoid having both File and Path in the same interface (the implementation could implement both interface, provided they use different names for the conflicting methods).