search

codehearts / lightdm-webkit-theme-tendou

㆝ A Windows 10 inspired theme for the lightdm webkit greeter
http://codehearts.github.io/lightdm-webkit-theme-tendou/
MIT License
23 stars 7 forks source link

Fixed multiple wait indicator displayed at once #23

Closed codehearts closed 7 years ago

codehearts commented 7 years ago

This resolves #16 by not showing or hiding the wait indicator unless is in the opposite state. Tests have been added for this.

I've also moved the wait indicator functions to the function prototype for Tendou, and prefixed private members with _.

codecov-io commented 7 years ago

Codecov Report

Merging #23 into develop will increase coverage by 3.2%. The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           develop      #23     +/-   ##
==========================================
+ Coverage    38.37%   41.57%   +3.2%     
==========================================
  Files            1        1             
  Lines          172      178      +6     
  Branches        16       18      +2     
==========================================
+ Hits            66       74      +8     
+ Misses         106      104      -2
Impacted Files Coverage Δ
js/main.js 41.57% <63.63%> (+3.2%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d6084b...6909687. Read the comment docs.

codecov-io commented 7 years ago

Codecov Report

Merging #23 into develop will increase coverage by 3.2%. The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           develop      #23     +/-   ##
==========================================
+ Coverage    38.37%   41.57%   +3.2%     
==========================================
  Files            1        1             
  Lines          172      178      +6     
  Branches        16       18      +2     
==========================================
+ Hits            66       74      +8     
+ Misses         106      104      -2
Impacted Files Coverage Δ
js/main.js 41.57% <63.63%> (+3.2%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d6084b...2e0690f. Read the comment docs.