codehenry / xmonad

Automatically exported from code.google.com/p/xmonad
0 stars 0 forks source link

_NET_WM_STATE_DEMANDS_ATTENTION support #532

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The _NET_WM_STATE_DEMANDS_ATTENTION atom is part of the EWMH specification and 
can be used to indicate that something happened in a window. It's apparently a 
somewhat weaker hint than the urgency flag of WM_HINTS, because EWMH say that 
windows expecting immediate attention should still use WM_HINTS.

Either way, the current UrgencyHook doesn't respect 
_NET_WM_STATE_DEMANDS_ATTENTION. This impacts amongst others all Qt 
applications, since Qt only uses ..._DEMANDS_ATTENTION and never WM_HINTS.

I patched UrgencyHook to also respect _NET_WM_STATE_DEMANDS_ATTENTION. I'm not 
much of a Haskell expert though, so I suggest someone takes a good look at it 
and point out what I did wrong.

Original issue reported on code.google.com by maar...@de-vri.es on 12 Feb 2013 at 6:28

Attachments:

GoogleCodeExporter commented 8 years ago
Here's a related issue: 
http://code.google.com/p/xmonad/issues/detail?id=481&start=100

Original comment by hanswc...@gmail.com on 12 Feb 2013 at 6:35

GoogleCodeExporter commented 8 years ago
Thanks Maarten. I've pushed the patch as-is. Some things might be done with 
less code:

dpy <- asks display

instead of

dpy <- withDisplay (\dpy -> return dpy)

But I don't have any actual errors to point out.

Original comment by vogt.a...@gmail.com on 19 Feb 2013 at 3:19