Parser content typehint [strict_types=1]

[John-Betong]

Info I have been trying for over a week to trace a new site's "Network connection Error" from going down overnight. No errors in logs so added "strict_types=1" to all PHP app and system PHP files, also set .env -> CI_ENVIRONMENT = development and eventually managed to get some errors reported.

Describe the bug incorrect type being passed.

CodeIgniter 4 version CI_VERSION 4.1.1

Affected module(s) File: ./system/View/Parser.php [code] protected function replaceSingle($pattern, $content, $template, bool $escape = false): string { // Any dollar signs in the pattern will be misinterpreted, so slash them $pattern = addcslashes($pattern, '$');

    // Flesh out the main pattern from the delimiters and escape the hash
    // See https://regex101.com/r/IKdUlk/1
    if (preg_match('/^(#)(.+)(#(m?s)?)$/s', $pattern, $parts))
    {
        $pattern = $parts[1] . addcslashes($parts[2], '#') . $parts[3];
    }

    // Replace the content in the template
    $template = preg_replace_callback($pattern, function ($matches) use ($content, $escape) {
        // Check for {! !} syntax to not escape this one.
        if (strpos($matches[0], '{!') === 0 && substr($matches[0], -2) === '!}')
        {
            $escape = false;
        }
        # KLUDGE - 2021-03-08 - force string instead of integer parameter
        return $this->prepareReplacement($matches, (string) $content, $escape);
    }, $template);

    return $template;
}

[/code]

Expected behavior, and steps to reproduce if appropriate I did not expect the web page to crash :(

Context OS: [Ubuntu 20.04.1] Web server [Apache 2] PHP version [8.0.3]

[MGatner]

I'm going to respond here in general for all these issues. You are creating a lot of work for the team in place of what could be a very quick and simple Pull Request. I you are unfamiliar or uncomfortable with git you could do these PRs directly from the GitHub interface.

I know you are a strong advocate of strict typing. The framework has moved greatly in the direction since implementing static analysis, but version 4 will never be guaranteed to be "strict safe" so if you are modifying system files to add that functionality you are creating your own bugs, not uncovering existing ones. I would be more charitable about this if you were creating PRs or well-formatted Issues (when appropriate) but I cannot have you generating work for an already tight team.

Take responsibility for these changes if you want to see them happen.

[John-Betong]

Regret raising these issues, I am not familiar with Git and thought they were issues about not Pull Requests.

As mentioned I have a new site and having problems for over a week and thought they were issues.q

Please delete all issues and I hope to revise with Pull Requests soon.