Array Validation Fails

[luispastendev]

hi there!

validation with more than 1 level only validates the first match.

Example:

// rule
'bar.*.foo' => [
    'rules' => 'required'
]

// data
"bar" => [
  [
    'foo' => 'baz'
  ],
  [
    'foo' => ''
  ]
]

the above validation should fails, however it passes. https://codeigniter4.github.io/userguide/libraries/validation.html#validating-keys-that-are-arrays

[WinterSilence]

@luispastendev it's wrong record, can you public your code?

'bar.*.foo' => [
    'rules' => 'required'
]

[luispastendev]

@WinterSilence you can test with this code

$validation = Services::Validation();

if(!$validation->setRules([
    'bar.*.foo' => [
        'rules' => 'required'
    ]
])->run([
    "bar" => [
        [
            'foo' => 'baz'
        ],
        [
            'foo' => ''
        ]
    ]
])){
    return $this->fail($validation->getErrors());
}

return $this->respond('ok!');

https://github.com/codeigniter4/CodeIgniter4/blob/03c5091ecc4d6e20388e617fdc75bfd2534f5233/system/Validation/Validation.php#L155

I was reviewing the code but it seems that it is only supported for selectors that end with *, but the documentation also mentions the possibility of doing something like the example above

If it is not a bug, I suppose that you should delete that text from the documentation

link: https://codeigniter4.github.io/userguide/libraries/validation.html#validating-keys-that-are-arrays

[WinterSilence]

$validation->setRules(['bar.*.foo' => 'required']);

not same to

->setRules(['bar.*.foo' => ['rules' => 'required']])

[luispastendev]

@WinterSilence the same result

[WinterSilence]

@luispastendev CI 4.1.1:

$result = \Config\Services::validation()
    ->setRules(['bar.*.foo' => 'required'])
    ->run([
        "bar" => [
            ['foo' => 'baz'],
            ['foo' => '']
        ]
    ]);
$result2 = \Config\Services::validation()
    ->setRules(['bar.*.foo' => 'required'])
    ->run([
        "bar" => [
            ['foo' => 'baz'],
            ['foo' => 'bar']
        ]
    ]);
$result3 = \Config\Services::validation()
    ->setRules(['bar.*.foo' => 'required'])
    ->run([
        "bar" => [
            ['foo2' => 'baz'],
            ['foo2' => 'bar']
        ]
    ]);
var_export([$result, $result2, $result3]); //  true, true, false

[luispastendev]

@WinterSilence I think the required rule should fail if an empty value is sent. taking your examples if you try the following fails and under what you explain it should return true

$result4 = \Config\Services::validation()
    ->setRules(['bar.*.foo' => 'required'])
    ->run([
        "bar" => [
            ['foo' => ''],
            ['foo' => '']
        ]
    ]);
    var_dump($result4); // currently returns false 

doc:

[WinterSilence]

@luispastendev all right, i fix my comment later

[WinterSilence]

@luispastendev but method really have other bug:

$result = \Config\Services::validation()
    ->setRules(['bar.*' => 'required'])
    ->run(["bar" => []]); // return true

[luispastendev]

@WinterSilence right! it only works if it detects something empty [''] that seems to be fixed with:

https://github.com/codeigniter4/CodeIgniter4/blob/03c5091ecc4d6e20388e617fdc75bfd2534f5233/system/Validation/Validation.php#L155

by the following:

if (is_array($value) && end($fieldNameToken) === '*' && ! empty($value))

but the other problem I do not know what others think at least reading the code I do not see an intention to support that use case