Closed michalsn closed 3 years ago
Describe the bug I came across this because some benchmarks stopped working: https://the-benchmarker.semaphoreci.com/jobs/21790820-d57f-4457-834e-2f93bdddef91. No matter what URL we would enter, the default route would be fired instead.
I started looking at it closely and figured out that new rules in the is_cli() function are the reason - exactly these:
is_cli()
if (stristr(PHP_SAPI, 'cgi') && getenv('TERM')) { return true; }
Values for these are:
PHP_SAPI => fpm-fcgi getenv('TERM') => xterm
Here is a Dockerfile: https://github.com/the-benchmarker/web-frameworks/blob/master/php/Dockerfile it can be tested by anyone.
CodeIgniter 4 version 4.1.3 and above
Affected module(s) is_cli() function
Sorry if this is a little chaotic - I can provide more information later if needed.
Fixed in 8d09d10.
8d09d10
paulbalandan
commented
3 years ago paulbalandan
commented
3 years ago
Describe the bug I came across this because some benchmarks stopped working: https://the-benchmarker.semaphoreci.com/jobs/21790820-d57f-4457-834e-2f93bdddef91. No matter what URL we would enter, the default route would be fired instead.
I started looking at it closely and figured out that new rules in the
is_cli()function are the reason - exactly these:Values for these are:
Here is a Dockerfile: https://github.com/the-benchmarker/web-frameworks/blob/master/php/Dockerfile it can be tested by anyone.
CodeIgniter 4 version 4.1.3 and above
Affected module(s)
is_cli()functionSorry if this is a little chaotic - I can provide more information later if needed.