search

codeigniter4 / CodeIgniter4

Open Source PHP Framework (originally from EllisLab)
https://codeigniter.com/
MIT License
5.4k stars 1.9k forks source link

Bug: Creation of dynamic property Config\Exceptions::$logDeprecations is deprecated #7097

Closed kenjis closed 1 year ago

kenjis commented 1 year ago

From Slack:

Deprecated: Creation of dynamic property Config\Exceptions::$logDeprecations is deprecated in ...\vendor\codeigniter4\framework\system\Debug\Exceptions.php on line 87 Deprecated: Creation of dynamic property Config\Exceptions::$deprecationLogLevel is deprecated in ...\vendor\codeigniter4\framework\system\Debug\Exceptions.php on line 88

PHP 8.2 & CI 4.3.0

paulbalandan commented 1 year ago

How is this our bug if we have indicated in the upgrade guide to add these two properties to app/Config/Exceptions.php?

Content Changes

The following files received significant changes (including deprecations or visual adjustments) and it is recommended that you merge the updated versions with your application: ...

  • app/Config/Exceptions.php Two additional public properties were added: $logDeprecations and $deprecationLogLevel. See See :ref:logging_deprecation_warnings for details.
kenjis commented 1 year ago

It is recommendation. But this is mandatory in PHP 8.2.

paulbalandan commented 1 year ago

Ah I see. Thanks for the clarification.