search

codeigniter4 / CodeIgniter4

Open Source PHP Framework (originally from EllisLab)
https://codeigniter.com/
MIT License
5.28k stars 1.88k forks source link

Dev: use Superglobals service and remove superglobals #7866

Open kenjis opened 12 months ago

kenjis commented 12 months ago

Use Services::superglobals() and remove all superglobals ($_SERVER, $_GET) in the code base (except in the Superglobals class).

https://github.com/codeigniter4/CodeIgniter4/blob/60b22bf6022f5979036a2fd309df6e3a00e89c05/system/Config/Services.php#L723

https://github.com/codeigniter4/CodeIgniter4/blob/60b22bf6022f5979036a2fd309df6e3a00e89c05/system/Superglobals.php#L19

paulbalandan commented 12 months ago

This is a good phpstan rule.