Open mkuettel opened 3 months ago
I confirmed the bug.
--- a/tests/system/Database/Live/ForgeTest.php
+++ b/tests/system/Database/Live/ForgeTest.php
@@ -1317,7 +1317,9 @@ final class ForgeTest extends CIUnitTestCase
$this->assertTrue($this->db->fieldExists('name', 'forge_test_two'));
- $this->forge->dropColumn('forge_test_two', 'name');
+ $return = $this->forge->dropColumn('forge_test_two', 'name');
+
+ $this->assertTrue($return);
$this->db->resetDataCache();
1) CodeIgniter\Database\Live\ForgeTest::testDropColumn
Failed asserting that false is true.
PHP Version
8.3
CodeIgniter4 Version
4.5.1
CodeIgniter4 Installation Method
Composer (as dependency to an existing project)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
cli
Database
SQLite3
What happened?
I was checking whether dropColumn of forge returned false when migrating down. Which always seemed to be the case. When checking the implementation I noticed that Forge expects from the driver that
_alterTable
returns a SQL statement to be executed, but in this case SQLite3 will return an empty string, because it runs multiple statements in the background, creating a new temporary table without the specified columns, moving data over and renaming afterwards.Steps to Reproduce
Expected Output
None, but the DatabaseException is thrown in the down() method, telling me that no error occured. But dropColumn() returned false, because the statement is empty.
Anything else?
No response