search

codeigniter4 / cache

PSR-6 and PSR-16 Cache Adapters for CodeIgniter 4
MIT License
8 stars 4 forks source link

Refresh toolkit #7

Closed MGatner closed 2 years ago

MGatner commented 2 years ago
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2542579317

Totals Coverage Status
Change from base Build 1235480783: -0.06%
Covered Lines: 138
Relevant Lines: 141
💛 - Coveralls
kenjis commented 2 years ago

This PR is a bit out of dated. I will update.

kenjis commented 2 years ago

The following test fails on PHP 8.0, but I can't reproduce on my local.

There was 1 failure:

1) CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired
Failed asserting that true is false.

/home/runner/work/cache/cache/vendor/cache/integration-tests/src/CachePoolTest.php:872

https://github.com/codeigniter4/cache/runs/6718288349?check_suite_focus=true

MGatner commented 2 years ago

Odd! The tests used to pass on Actions. I just looked at the code and it seems fine? Maybe it is a timezone issue?

MGatner commented 2 years ago

README badges will need to be updated as well.

kenjis commented 2 years ago

The GitHub auth error occurs many times on this repository.

Could not authenticate against github.com

Probably the repositories is the cause. https://github.com/codeigniter4/cache/blob/b965e7f51a1575a1fce49035886c7fbdaf87190a/composer.json#L54-L59

kenjis commented 2 years ago

README badges will need to be updated as well.

Updated.

MGatner commented 2 years ago

Probably the repositories is the cause.

Most definitely. I've been removing this from all my projects and I no longer get the Auth issue. This should switch to codeigniter4/framework: ^4.1 and drop the repositories key.

MGatner commented 2 years ago

Thanks for your help on this one! I let that sit stale way too long 😅