Closed MGatner closed 2 years ago
Totals | |
---|---|
Change from base Build 1235480783: | -0.06% |
Covered Lines: | 138 |
Relevant Lines: | 141 |
This PR is a bit out of dated. I will update.
The following test fails on PHP 8.0, but I can't reproduce on my local.
There was 1 failure:
1) CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired
Failed asserting that true is false.
/home/runner/work/cache/cache/vendor/cache/integration-tests/src/CachePoolTest.php:872
https://github.com/codeigniter4/cache/runs/6718288349?check_suite_focus=true
Odd! The tests used to pass on Actions. I just looked at the code and it seems fine? Maybe it is a timezone issue?
README badges will need to be updated as well.
The GitHub auth error occurs many times on this repository.
Could not authenticate against github.com
Probably the repositories is the cause. https://github.com/codeigniter4/cache/blob/b965e7f51a1575a1fce49035886c7fbdaf87190a/composer.json#L54-L59
README badges will need to be updated as well.
Updated.
Probably the repositories is the cause.
Most definitely. I've been removing this from all my projects and I no longer get the Auth issue. This should switch to codeigniter4/framework: ^4.1
and drop the repositories key.
Thanks for your help on this one! I let that sit stale way too long 😅
^1.0