codeigniter4 / shield

Authentication and Authorization for CodeIgniter 4
https://shield.codeigniter.com
MIT License
351 stars 123 forks source link

docs: run rector for fix rector errors #1085

Closed datamweb closed 3 months ago

datamweb commented 3 months ago

Description See https://github.com/codeigniter4/shield/actions/runs/8571440801/job/23491670281?pr=1084

1) src/Filters/AuthRates.php:58

    ---------- begin diff ----------
@@ @@
     /**
      * We don't have anything to do here.
      *
-     * @param Response|ResponseInterface $response
      * @param array|null                 $arguments
      */
     public function after(RequestInterface $request, ResponseInterface $response, $arguments = null): void
    ----------- end diff -----------

Applied rules:
 * RemoveUselessParamTagRector

Checklist:

samsonasik commented 3 months ago

@kenjis similar to https://github.com/codeigniter4/CodeIgniter4/pull/8701 could you verify it?

kenjis commented 3 months ago

I didn't notice this PR was merged into the PR that dependabot created.

We do not accept merge commits in PRs, so the GitHub Action check failed by the merge commit. So I told dependabot to rebase, but cannot rebase because of the commit. So I told dependabot to recreate. Then the changes in this PR has gone.

@datamweb The workflow did not work. So send PR like this to develop in the future.