Closed michalsn closed 4 months ago
This Session class is already very long, and would violate the SRP. Don't we need a new class for these methods?
The methods related to the user session will give us about 50 lines of code. I don't see the point of moving them to a separate class - especially if they are to remain non-public.
The session data manipulation is needed only for the Session authenticator. So extracting them into a class does not seem to help much in the future. If we extract classes, we should extract another functions, but so far there is no need.
By the way, is this an enhancement or a bug fix? In other words, should the next release be minor version up?
I would say this is an enhancement.
Then it should be released as v1.1.0.
Okay. I'm not familiar with the Shield release cycle, so it's up to you when you'd like to merge this.
Description This PR changes the session manipulation methods from
private
toprotected
, so we can use them if we extend theAuthentication\Authenticators\Session
class.Reference: https://github.com/codeigniter4/shield/discussions/1111
Checklist: