codeigniter4 / shield

Authentication and Authorization for CodeIgniter 4
https://shield.codeigniter.com
MIT License
365 stars 133 forks source link

fix: `shield:user create` does not assign a default group #1162

Closed kenjis closed 3 months ago

kenjis commented 3 months ago

Description Supersedes #999 Fixes #998

The user registration form sets the default group value for the user when a new user is registered. But the command shield:user create does not set the default group. I think we should fix the inconsistency as a bug.

What do you think about reading the available roles from the config file and presenting that as a required choice to the user? https://github.com/codeigniter4/shield/pull/999#issuecomment-1890845904

It would be nice, but nobody has implemented it. It can be implemented as enhancement later.

Checklist:

kenjis commented 3 months ago

Oh, I have not read the comment carefully. Thanks.

And @bgeneto suggested -g option instead of showing groups and the user interaction. https://github.com/codeigniter4/shield/pull/999#issuecomment-1895726347

datamweb commented 3 months ago

suggested -g option

I like this because of less user interactions.

kenjis commented 3 months ago

I sent a PR to implement -g option: #1164