search

codeigniter4 / shield

Authentication and Authorization for CodeIgniter 4
https://shield.codeigniter.com
MIT License
354 stars 127 forks source link

refactor: remove unneeded Entities\Cast\IntBoolCast #1187

Closed grimpirate closed 2 weeks ago

grimpirate commented 2 weeks ago

Description Reopening of Pull Request #1186 as I deleted the repository prematurely.

kenjis commented 2 weeks ago

Thank you for sending this PR. Please fix all errors in GitHub Actions. If you have questions, feel free to ask.

grimpirate commented 2 weeks ago

@kenjis The unsuccessful checks appear to be during phpstan and rector complaining that they can no longer find the IntBoolCast and Entity classes. Those are unneeded and therefore deleted. Not sure how to fix the GitHub actions.

kenjis commented 2 weeks ago

The commit is not GPG signed. Please sign all commits. See https://github.com/codeigniter4/shield/pull/1117#issuecomment-2118864100

grimpirate commented 2 weeks ago

@kenjis I'll have to open a new PR. I used the web editor and was trying to squash the php stan edits as I couldn't do it on the web. Sorry about that.

kenjis commented 2 weeks ago

Okay, no problem.

But I recommend you learn how to use:

If you learn them, you could manipulate git commits freely and easily on your local machine.