codeigniter4 / shield

Authentication and Authorization for CodeIgniter 4
https://shield.codeigniter.com
MIT License
365 stars 133 forks source link

feat: improve query performance for `find*()` #1192

Closed datamweb closed 2 months ago

datamweb commented 2 months ago

Description This Pull Request introduces a database migration that adds an index to the deleted_at column in the users table. This change is intended to enhance the performance of queries that filter based on the deleted_at field, particularly for cases involving soft deletes.

Checklist:

kenjis commented 2 months ago

This needs to be carefully considered. See https://tech-torana-co-jp.translate.goog/entry/2023/11/27/123000?_x_tr_sl=ja&_x_tr_tl=en&_x_tr_hl=ja&_x_tr_pto=wapp

datamweb commented 2 months ago

Hi Kenjis, I did some research on this and it seems like it won’t have a positive impact. So, I’m going to close it. Thanks for the link you shared!"