search

codeigniter4 / tasks

Task Scheduler for CodeIgnter 4
https://tasks.codeigniter.com/
MIT License
96 stars 21 forks source link

CodeIgniter DevKit #43

Closed MGatner closed 2 years ago

MGatner commented 2 years ago

This PR switches the underlying toolkit to use the CodeIgniter DevKit. Some things to point out:

  1. The minimum PHP version is now 7.4, to match the framework's upcoming changes
  2. Corollary, all properties that can be typed have been
  3. Removes Mockery since it wasn't being used
MGatner commented 2 years ago

Something is up with GitHub Actions. I will rerun the jobs in a bit.

kenjis commented 2 years ago

@MGatner I mistakenly assumed that since this was a new repository, I could specify the types perfectly.

kenjis commented 2 years ago

Mutation Testing makes the review difficult.

kenjis commented 2 years ago

This is not related this PR, but I recommend to add final keyword to all classes that you do not intend to be extended.

MGatner commented 2 years ago

Mutation Testing makes the review difficult.

The mutation annotations will mostly be beyond any actual modified code. GitHub usually puts a line in there that tells you when there are no more changes, if that helps.

MGatner commented 2 years ago

This is not related this PR, but I recommend to add final keyword to all classes that you do not intend to be extended.

I fully agree. Also every method should be consider for scope, final, and @internal. The framework has taught us how important it is to get this right before initial release.

MGatner commented 2 years ago

Something is screwy with GitHub Actions authentication. All of these tests have passed and the only change was specifying the Time return type so I am going to proceed.