Closed davislasis closed 3 years ago
Please rebase and GPG sign your commits.
I did add GPG key to my git profile, how can add that to commit through PHPStorm? Maybe i should make a new commit and pull request?
I'm not familiar with phpstorm but check if there is a setting that enforces signed commits.
If not, you can do it manually.
git commit -S -m 'Your commit message.'
Also, please use the short format of the header licenses to be consistent with the main repo.
What is short format of the header licenses? As Travis tests failed with missing and unnecessary keys, i guess i need to wait until CI 4.1 to come out and then push LV language in?
What is short format of the header licenses? As Travis tests failed with missing and unnecessary keys, i guess i need to wait until CI 4.1 to come out and then push LV language in?
The short format was just merged earlier. You can check that existing doc headers got changed. Also, I made a PR to change the comparison to the latest language strings in the main repo. Just waiting feedback from others.
"Merging is blocked" remove un-signed commit(s)
Maybe you can squash your commits and have a single signed commit? Currently, merging is blocked once all commits are GPG signed.
Another, please add your info in the README
and remove lv from MISSING
.
in a few hours i will be home from work, i guess most reasonable would be to delete this PR and commits and create a brand new and clean commit with PR
Added new Latvian language translations