search

codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

New language: Latvian #137

Closed davislasis closed 3 years ago

davislasis commented 3 years ago

Added new Latvian language translations

paulbalandan commented 3 years ago

Please rebase and GPG sign your commits.

davislasis commented 3 years ago

I did add GPG key to my git profile, how can add that to commit through PHPStorm? Maybe i should make a new commit and pull request?

paulbalandan commented 3 years ago

I'm not familiar with phpstorm but check if there is a setting that enforces signed commits.

If not, you can do it manually. git commit -S -m 'Your commit message.'

paulbalandan commented 3 years ago

Also, please use the short format of the header licenses to be consistent with the main repo.

davislasis commented 3 years ago

What is short format of the header licenses? As Travis tests failed with missing and unnecessary keys, i guess i need to wait until CI 4.1 to come out and then push LV language in?

paulbalandan commented 3 years ago

What is short format of the header licenses? As Travis tests failed with missing and unnecessary keys, i guess i need to wait until CI 4.1 to come out and then push LV language in?

The short format was just merged earlier. You can check that existing doc headers got changed. Also, I made a PR to change the comparison to the latest language strings in the main repo. Just waiting feedback from others.

totoprayogo1916 commented 3 years ago

"Merging is blocked" remove un-signed commit(s)

paulbalandan commented 3 years ago

Maybe you can squash your commits and have a single signed commit? Currently, merging is blocked once all commits are GPG signed.

Another, please add your info in the README and remove lv from MISSING.

davislasis commented 3 years ago

in a few hours i will be home from work, i guess most reasonable would be to delete this PR and commits and create a brand new and clean commit with PR