search

codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

New language: Latvian. #140

Closed davislasis closed 3 years ago

davislasis commented 3 years ago

New language: Latvian.

davislasis commented 3 years ago

@paulbalandan why JA language keys are merged few hours ago https://github.com/codeigniter4/translations/pull/124 and my PR now fails because of that? Even if i would need to add those keys in LV, Travis don't fail with missing keys https://travis-ci.org/github/codeigniter4/translations/jobs/745687868 https://travis-ci.org/github/codeigniter4/translations/jobs/745687869

Either way there is something wrong, could you please guide the best approach through this?

paulbalandan commented 3 years ago

Ok. So that's why Travis didn't run on JA. Either way it's not your fault as while I'm waiting for this test to finish I merged that. I am currently coming up with a test case that will just test the locale of the changed files. I am just looking for the best way to retrieve the list of changed files in a PR. Also, the added JA keys should not be a worry as before this gets a release alongside the 4.1 release these keys should have been added to all locales.