search

codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[All languages] Remove deprecated files according to main repo. #163

Closed sfadschm closed 3 years ago

sfadschm commented 3 years ago

This removes deprecated files in all languages according to #3950 of the main repo.

sfadschm commented 3 years ago

Also removed Seed.php which is deprecated, too.

sfadschm commented 3 years ago

Removed Migration.badCreateName and Migrations.writeError. This way, the only thing left to do in all languages is to translated missing keys, but they are otherwise clean.

I'm thinking whether to also remove keys which have been added to translations, but not translated (i.e. where the english message has just been copied). Opinions?

sba commented 3 years ago

I would leave the untranslated (english) strings, in the files. This makes it easier for someone to translate it without paying attention to code style, order etc. And the build checks do not fail.

sfadschm commented 3 years ago

Fine with that, too. Actually, the intention was to have the tests fail to represent the "true" translation state.