codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[zh-CN] add missing translation(Time.php) #258

Closed jnwangpai closed 2 years ago

kenjis commented 2 years ago

Thank you for sending PR.

It seems there are missing files and keys.

Failed asserting that language files "Cookie.php", "Email.php", "Encryption.php", "Fabricator.php", "Publisher.php", "RESTful.php", "Security.php", "Test.php" in the main repository are translated in "zh-CN" locale.

Failed asserting that the language keys "CLI.altCommandPlural", "CLI.altCommandSingular", "CLI.generator", "CLI.namespaceNotDefined", "Cast.baseCastMissing", "Cast.invalidCastMethod", "Cast.invalidTimestamp", "Core.enabledZlibOutputCompression", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.fieldNotExists", "Database.forEmptyInputGiven", "Database.forFindColumnHaveMultipleColumns", "Database.noDateFormat", "Database.noPrimaryKey", "Database.tableNotFound", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.invalidSameSiteSetting", "Images.fileNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.batch", "Migrations.batchNotFound", "Migrations.generalFault", "Migrations.group", "Migrations.latest", "Migrations.nameSeeder", "Migrations.namespace", "Migrations.refreshConfirm", "Migrations.rollBackConfirm", "Session.invalidSameSiteSetting", "Validation.alpha_numeric_punct", "Validation.equals", "Validation.hex", "Validation.is_not_unique", "Validation.not_equals", "Validation.not_in_list", "Validation.string" in the main repository are included for translation in "zh-CN" locale.

https://github.com/codeigniter4/translations/runs/4334099954?check_suite_focus=true

You can check any time on your local:

$ bin/test zh-CN
paulbalandan commented 2 years ago

Hi @windpie1 thank you for the changes. It seems there are still untranslated items. Can you take a look and supply those missing?

1) Translations\Tests\SimpleChineseTranslationTest::testAllConfiguredLanguageFilesAreTranslated with data set "zh-CN" ('zh-CN') Failed asserting that language files "Cookie.php", "Email.php", "Encryption.php", "Fabricator.php", "Publisher.php", "RESTful.php", "Security.php", "Test.php" in the main repository are translated in "zh-CN" locale. Failed asserting that an array is empty.

2) Translations\Tests\SimpleChineseTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "zh-CN" ('zh-CN') Failed asserting that the language keys "CLI.altCommandPlural", "CLI.altCommandSingular", "CLI.generator", "CLI.namespaceNotDefined", "Cast.baseCastMissing", "Cast.invalidCastMethod", "Cast.invalidTimestamp", "Core.enabledZlibOutputCompression", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.fieldNotExists", "Database.forEmptyInputGiven", "Database.forFindColumnHaveMultipleColumns", "Database.noDateFormat", "Database.noPrimaryKey", "Database.tableNotFound", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.invalidSameSiteSetting", "Images.fileNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.batch", "Migrations.batchNotFound", "Migrations.generalFault", "Migrations.group", "Migrations.latest", "Migrations.nameSeeder", "Migrations.namespace", "Migrations.refreshConfirm", "Migrations.rollBackConfirm", "Session.invalidSameSiteSetting", "Validation.alpha_numeric_punct", "Validation.equals", "Validation.hex", "Validation.is_not_unique", "Validation.not_equals", "Validation.not_in_list", "Validation.string" in the main repository are included for translation in "zh-CN" locale. Failed asserting that an array is empty.

paulbalandan commented 2 years ago

I've checked with latest develop and changes in this PR are already covered. Closing as such.