codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[zh-CN] Update translations #275

Closed vibbow closed 2 years ago

vibbow commented 2 years ago

More fix on the way.

kenjis commented 2 years ago

There was 1 failure:

1) Translations\Tests\SimpleChineseTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "zh-CN" ('zh-CN') Failed asserting that the translated language keys "Images.copyFailed", "Images.jpgOrPngRequired", "Images.missingFont", "Images.rotateUnsupported", "Migrations.migCreate", "Migrations.migHelpRefresh", "Migrations.migHelpRollback", "Migrations.migHelpSeed", "Migrations.migNumberError", "Migrations.nameMigration" in "zh-CN" locale differ from the original keys in the main repository.

vibbow commented 2 years ago

There was 1 failure:

1. Translations\Tests\SimpleChineseTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "zh-CN" ('zh-CN')
   Failed asserting that the translated language keys "Images.copyFailed", "Images.jpgOrPngRequired", "Images.missingFont", "Images.rotateUnsupported", "Migrations.migCreate", "Migrations.migHelpRefresh", "Migrations.migHelpRollback", "Migrations.migHelpSeed", "Migrations.migNumberError", "Migrations.nameMigration" in "zh-CN" locale differ from the original keys in the main repository.

Because I didn't find where are they used for, so I leave them as untranslated.

I'll translate those now.

paulbalandan commented 2 years ago

@vibbow, why did you close this? It seems tests pass

vibbow commented 2 years ago

@vibbow, why did you close this? It seems tests pass

Oh, I saw it already been approvied, so I closed this.

kenjis commented 2 years ago

@paulbalandan Why was zh-TW tests run?

There were 2 failures:

1) Translations\Tests\TraditionalChineseTranslationTest::testAllConfiguredLanguageFilesAreTranslated with data set "zh-TW" ('zh-TW') Failed asserting that language files "Publisher.php", "Test.php" in the main repository are translated in "zh-TW" locale. Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:104 /home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97

2) Translations\Tests\TraditionalChineseTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "zh-TW" ('zh-TW') Failed asserting that the language keys "Files.expectedDirectory", "Files.expectedFile" in the main repository are included for translation in "zh-TW" locale. Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:162 /home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97

FAILURES! Tests: 7, Assertions: 7, Failures: 2. Some locales have failed the tests!

Passed locales (1 of 2): zh-CN Failed locales (1 of 2): zh-TW

kenjis commented 2 years ago

@vibbow Approved is not merged. Close means to take down this PR.

kenjis commented 2 years ago

@paulbalandan

$ git diff --name-only --diff-filter=ACMRTUXB origin/develop..HEAD
Language/zh-CN/CLI.php
Language/zh-CN/Cache.php
Language/zh-CN/Cast.php
Language/zh-CN/Cookie.php
Language/zh-CN/Core.php
Language/zh-CN/Database.php
Language/zh-CN/Email.php
Language/zh-CN/Encryption.php
Language/zh-CN/Fabricator.php
Language/zh-CN/Files.php
Language/zh-CN/Filters.php
Language/zh-CN/Format.php
Language/zh-CN/HTTP.php
Language/zh-CN/Images.php
Language/zh-CN/Log.php
Language/zh-CN/Migrations.php
Language/zh-CN/Number.php
Language/zh-CN/Pager.php
Language/zh-CN/Publisher.php
Language/zh-CN/RESTful.php
Language/zh-CN/Router.php
Language/zh-CN/Security.php
Language/zh-CN/Session.php
Language/zh-CN/Test.php
Language/zh-CN/Time.php
Language/zh-CN/Validation.php
Language/zh-CN/View.php
Language/zh-TW/Files.php
Language/zh-TW/Migrations.php
Language/zh-TW/Validation.php
vibbow commented 2 years ago

Emm, did I mess something up?

kenjis commented 2 years ago

@paulbalandan I got the reason. This PR branch is not sync with the latest develop.

It seems this is intended behavior. zh-CN tests passed. So we ignore zh-TW test fails, right?

Passed locales (1 of 2): zh-CN
Failed locales (1 of 2): zh-TW
kenjis commented 2 years ago

@vibbow

Emm, did I mess something up?

No. No problem.

But If you rebase this branch, all tests would pass.

$ git checkout zh-CN
$ git fetch upstream
$ git rebase upstream/develop
$ git push --force-with-lease origin zh-CN
paulbalandan commented 2 years ago

Thank you, @vibbow