search

codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[de] Create Errors.php #317

Closed sba closed 1 year ago

sba commented 2 years ago

german translation file for strings added in 4.3

kenjis commented 2 years ago

@paulbalandan https://github.com/codeigniter4/CodeIgniter4/pull/6288 is merged into 4.3 branch. So the new lang file does not exist in develop branch.

What do we do?

paulbalandan commented 2 years ago

The tests were designed to test against develop only. So, I guess hold this off until 4.3 gets merged to develop?

kenjis commented 2 years ago

I see. I'm not sure but it might be a good way.

kenjis commented 1 year ago

1) Translations\Tests\GermanTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "de" ('de') Failed asserting that the language key "HTTP.localeNotSupported" in the main repository is included for translation in "de" locale. Failed asserting that an array is empty.

paulbalandan commented 1 year ago

@sba will you be able to address the failing tests?

sba commented 1 year ago

@sba will you be able to address the failing tests?

the missing key I added, but I don't know what causes Failed asserting that an array is empty.

kenjis commented 1 year ago

@sba It is the same error with Failed asserting that the language key "HTTP.localeNotSupported" in the main repository is included for translation in "de" locale. It is original error message from PHPUnit.