codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[fa] Add missing translations #323

Closed k-msalehi closed 2 years ago

kenjis commented 2 years ago

Thank you!

But it seems there are some missing translations. Can you fix?

There were 2 failures:

1) Translations\Tests\FarsiTranslationTest::testAllConfiguredLanguageFilesAreTranslated with data set "fa" ('fa')
Failed asserting that language files "CLI.php", "Cast.php", "Cookie.php", "Encryption.php", "Fabricator.php", "Filters.php", "Publisher.php", "RESTful.php", "Security.php", "Test.php" in the main repository are translated in "fa" locale.
Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:108
phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97

2) Translations\Tests\FarsiTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "fa" ('fa')
Failed asserting that the language keys "Core.enabledZlibOutputCompression", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.fieldNotExists", "Database.forEmptyInputGiven", "Database.forFindColumnHaveMultipleColumns", "Database.methodNotAvailable", "Database.noDateFormat", "Database.noPrimaryKey", "Database.parseStringFail", "Database.tableNotFound", "Email.exitStatus", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.controllerNotFound", "HTTP.emptyController", "HTTP.invalidSameSiteSetting", "HTTP.methodNotFound", "Images.fileNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.added", "Migrations.batch", "Migrations.batchNotFound", "Migrations.filename", "Migrations.generalFault", "Migrations.group", "Migrations.latest", "Migrations.migCreate", "Migrations.migHelpCurrent", "Migrations.migHelpLatest", "Migrations.migHelpRefresh", "Migrations.migHelpRollback", "Migrations.migHelpSeed", "Migrations.migHelpVersion", "Migrations.migInvalidVersion", "Migrations.migMissingSeeder", "Migrations.migNumberError", "Migrations.migSeeder", "Migrations.migrated", "Migrations.nameMigration", "Migrations.nameSeeder", "Migrations.namespace", "Migrations.noneFound", "Migrations.on", "Migrations.refreshConfirm", "Migrations.removed", "Migrations.rollBackConfirm", "Migrations.rollingBack", "Migrations.toVersion", "Migrations.toVersionPH", "Migrations.version", "Router.invalidControllerName", "Router.invalidDynamicController", "Session.invalidSameSiteSetting", "Time.invalidFormat", "Validation.alpha_numeric_punct", "Validation.equals", "Validation.hex", "Validation.is_not_unique", "Validation.not_equals", "Validation.not_in_list", "Validation.string", "View.invalidCellClass", "View.invalidDecoratorClass", "View.noCellClass", "View.tagSyntaxError" in the main repository are included for translation in "fa" locale.
Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:166
phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97
k-msalehi commented 2 years ago

It may take a while, but I'll work on it.

k-msalehi commented 2 years ago

Language/Cast.php should be removed

Thanks. It still exists in the CI4 fresh installation.

paulbalandan commented 2 years ago

Language/Cast.php should be removed

Thanks. It still exists in the CI4 fresh installation.

@totoprayogo1916 meant was to move Language/Cast.php to Language/fa/Cast.php

k-msalehi commented 2 years ago

Why all changes for most of the files are gone? Last update is 12 months ago

paulbalandan commented 2 years ago

It seems the maintainer for this locale is not active. If you have time, you can replace as maintainer.

k-msalehi commented 2 years ago

@paulbalandan Yes please.

paulbalandan commented 2 years ago

Thank you, @msalehi-d