codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

update `ko` #359

Closed Terrorboy closed 1 year ago

Terrorboy commented 1 year ago
Terrorboy commented 1 year ago

https://github.com/codeigniter4/translations/issues/357 -> https://github.com/codeigniter4/translations/pull/359/commits/48763b784738ac1614c02a09bd7d79e0ee42fd74

paulbalandan commented 1 year ago

Why is sv-SE included here?

Terrorboy commented 1 year ago

I mentioned sv-SE accidentally in the content and I don't understand why it's working in the test code. I am also trying to find out why it's happening as there is no sv-SE related setting in the modified file.

@paulbalandan

https://github.com/codeigniter4/translations/pull/359/files

paulbalandan commented 1 year ago

I also don't understand. Can you try rebasing your PR against latest develop?

Terrorboy commented 1 year ago

Can you run this again: https://github.com/codeigniter4/translations/actions/runs/3901437760 @paulbalandan

Terrorboy commented 1 year ago

I have made several modifications while doing PR and I suspect that something got merged in the middle, causing it to become tangled. But now it seems to be working fine.