Closed hafijul233 closed 1 year ago
1) Translations\Tests\AutoReview\TranslationsCodeTest::testLocalesArrayAreArrangedByLocaleCode
The `AbstractTranslationTestCase::$locales` property should be arranged by locale code.
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
'Translations\Tests\ArabicTranslationTest' => 'ar'
+ 'Translations\Tests\BengaliTranslationTest' => 'bn'
'Translations\Tests\BulgarianTranslationTest' => 'bg'
- 'Translations\Tests\BengaliTranslationTest' => 'bn'
'Translations\Tests\BosnianTranslationTest' => 'bs'
'Translations\Tests\CzechTranslationTest' => 'cs'
'Translations\Tests\GermanTranslationTest' => 'de'
/home/runner/work/translations/translations/tests/AutoReview/TranslationsCodeTest.php:34
phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97
https://github.com/codeigniter4/translations/actions/runs/3918893688/jobs/6700568666
1) Translations\Tests\BengaliTranslationTest::testAllConfiguredLanguageFilesAreTranslated with data set "bn" ('bn')
Failed asserting that language file "Errors.php" in the main repository is translated in "bn" locale.
Failed asserting that an array is empty.
/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:109
phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97
2) Translations\Tests\BengaliTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "bn" ('bn')
Failed asserting that the translated language key "Number.quadrillion" in "bn" locale differs from the original keys in the main repository.
Failed asserting that an array is empty.
/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:257
phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97
https://github.com/codeigniter4/translations/actions/runs/3918893697/jobs/6700550315
@hafijul233 Can you fix for the failed checks?
@hafijul233 You forgot GPG signing. Please sign all your commits. See
@hafijul233 Can you fix for the failed checks?
I have fixed it. https://github.com/hafijul233/ci4-translations/commit/43061e769894955eb6fd58c1671d9d86102bfb8b
1) Translations\Tests\AutoReview\TranslationsCodeTest::testLocalesArrayAreArrangedByLocaleCode The `AbstractTranslationTestCase::$locales` property should be arranged by locale code. Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( 'Translations\Tests\ArabicTranslationTest' => 'ar' + 'Translations\Tests\BengaliTranslationTest' => 'bn' 'Translations\Tests\BulgarianTranslationTest' => 'bg' - 'Translations\Tests\BengaliTranslationTest' => 'bn' 'Translations\Tests\BosnianTranslationTest' => 'bs' 'Translations\Tests\CzechTranslationTest' => 'cs' 'Translations\Tests\GermanTranslationTest' => 'de' /home/runner/work/translations/translations/tests/AutoReview/TranslationsCodeTest.php:34 phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:97
https://github.com/codeigniter4/translations/actions/runs/3918893688/jobs/6700568666
I have fixed it also
I have added the bengali language translation for all of the message. Here is the list