codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

Test cannot detect missing lang item in array #364

Closed kenjis closed 1 year ago

kenjis commented 1 year ago

CLI.generator.viewName.cell is missing in ja, but tests pass. See https://codeigniter4.github.io/translations/ja.html

en:

return [
    'altCommandPlural'   => 'Did you mean one of these?',
    'altCommandSingular' => 'Did you mean this?',
    'commandNotFound'    => 'Command "{0}" not found.',
    'generator'          => [
        // ...
        'usingCINamespace' => 'Warning: Using the "CodeIgniter" namespace will generate the file in the system directory.',
        'viewName'         => [
            'cell' => 'Cell view name',
        ],
    ],
    // ...

ja:

return [
    'altCommandPlural'   => 'この中の1つですか?', // 'Did you mean one of these?'
    'altCommandSingular' => 'これですか?', // 'Did you mean this?'
    'commandNotFound'    => '"{0}" というコマンドはありません。', // 'Command "{0}" not found.'
    'generator'          => [
        // ...
        'usingCINamespace' => '警告: 名前空間 "CodeIgniter" を使用するとsystemディレクトリにファイルが生成されます。', // 'Warning: Using the "CodeIgniter" namespace will generate the file in the system directory.'
    ],
    // ...
Terrorboy commented 1 year ago

image

paulbalandan commented 1 year ago

It seems array_diff_key in testAllConfiguredLanguageKeysAreIncluded is not enough to detect multi-level arrays.