codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[ru] fix grammar errors and add missing items #372

Closed MalkoVrinto closed 1 year ago

MalkoVrinto commented 1 year ago

fixed some grammar errors

kenjis commented 1 year ago

Thank you for sending updates.

But it seems there are many missing translation items. See https://github.com/codeigniter4/translations/actions/runs/4270646474/jobs/7439409028 Can you add them?

MalkoVrinto commented 1 year ago

Thank you for sending updates.

But it seems there are many missing translation items. See https://github.com/codeigniter4/translations/actions/runs/4270646474/jobs/7439409028 Can you add them?

With my pleasure

P.S. Added missed: Cookie.php Errors.php Publisher.php Security.php Test.php

kenjis commented 1 year ago

Thank you for adding files!

These items are not translated:

Failed asserting that the language keys "CLI.altCommandPlural", "CLI.altCommandSingular", "CLI.generator.cancelOperation", "CLI.generator.className.cell", "CLI.generator.className.command", "CLI.generator.className.config", "CLI.generator.className.controller", "CLI.generator.className.default", "CLI.generator.className.entity", "CLI.generator.className.filter", "CLI.generator.className.migration", "CLI.generator.className.model", "CLI.generator.className.seeder", "CLI.generator.className.validation", "CLI.generator.commandType", "CLI.generator.databaseGroup", "CLI.generator.fileCreate", "CLI.generator.fileError", "CLI.generator.fileExist", "CLI.generator.fileOverwrite", "CLI.generator.parentClass", "CLI.generator.returnType", "CLI.generator.tableName", "CLI.generator.usingCINamespace", "CLI.generator.viewName.cell", "CLI.namespaceNotDefined", "Cast.baseCastMissing", "Cast.invalidCastMethod", "Cast.invalidTimestamp", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.methodNotAvailable", "Fabricator.createFailed", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.invalidSameSiteSetting", "HTTP.localeNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.batch", "Migrations.group", "Migrations.migrated", "Migrations.nameSeeder", "Migrations.namespace", "Router.invalidControllerName", "Router.invalidDynamicController", "Session.invalidSameSiteSetting", "Time.invalidFormat", "Validation.not_in_list", "Validation.valid_json", "View.invalidDecoratorClass" in the main repository are included for translation in "ru" locale. https://github.com/codeigniter4/translations/actions/runs/4305274333/jobs/7517427605

MalkoVrinto commented 1 year ago

Thank you for adding files!

These items are not translated:

Failed asserting that the language keys "CLI.altCommandPlural", "CLI.altCommandSingular", "CLI.generator.cancelOperation", "CLI.generator.className.cell", "CLI.generator.className.command", "CLI.generator.className.config", "CLI.generator.className.controller", "CLI.generator.className.default", "CLI.generator.className.entity", "CLI.generator.className.filter", "CLI.generator.className.migration", "CLI.generator.className.model", "CLI.generator.className.seeder", "CLI.generator.className.validation", "CLI.generator.commandType", "CLI.generator.databaseGroup", "CLI.generator.fileCreate", "CLI.generator.fileError", "CLI.generator.fileExist", "CLI.generator.fileOverwrite", "CLI.generator.parentClass", "CLI.generator.returnType", "CLI.generator.tableName", "CLI.generator.usingCINamespace", "CLI.generator.viewName.cell", "CLI.namespaceNotDefined", "Cast.baseCastMissing", "Cast.invalidCastMethod", "Cast.invalidTimestamp", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.methodNotAvailable", "Fabricator.createFailed", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.invalidSameSiteSetting", "HTTP.localeNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.batch", "Migrations.group", "Migrations.migrated", "Migrations.nameSeeder", "Migrations.namespace", "Router.invalidControllerName", "Router.invalidDynamicController", "Session.invalidSameSiteSetting", "Time.invalidFormat", "Validation.not_in_list", "Validation.valid_json", "View.invalidDecoratorClass" in the main repository are included for translation in "ru" locale. https://github.com/codeigniter4/translations/actions/runs/4305274333/jobs/7517427605

Already translated :)

paulbalandan commented 1 year ago

Thank you, @MalkoVrinto for your contribution!

MalkoVrinto commented 1 year ago

Thank you, @MalkoVrinto for your contribution!

:handshake:

kenjis commented 1 year ago

It seems ru is broken now.

1) Translations\Tests\RussianTranslationTest::testAllConfiguredLanguageKeysAreInOrder with data set "ru" ('ru')
Failed asserting that the translated language keys in "ru" locale are ordered correctly.
--- Original
+++ Translated

Migrations.php:
-'migSeeder' => 'Seeder name';
+'on' => 'Миграция на: ';
Failed asserting that an array is empty.

See https://github.com/codeigniter4/translations/actions/runs/4370681286/jobs/7645827066

MalkoVrinto commented 1 year ago

It seems ru is broken now.

1) Translations\Tests\RussianTranslationTest::testAllConfiguredLanguageKeysAreInOrder with data set "ru" ('ru')
Failed asserting that the translated language keys in "ru" locale are ordered correctly.
--- Original
+++ Translated

Migrations.php:
-'migSeeder' => 'Seeder name';
+'on' => 'Миграция на: ';
Failed asserting that an array is empty.

See https://github.com/codeigniter4/translations/actions/runs/4370681286/jobs/7645827066

The keys in Migrations.php are ordered correctly now.

kenjis commented 1 year ago

The keys in Migrations.php are not ordered correctly: https://github.com/codeigniter4/translations/blob/5b7fc9df6c09a2840649c9165804db46839936bd/Language/ru/Migrations.php#L45-L46 https://github.com/codeigniter4/translations/blob/5b7fc9df6c09a2840649c9165804db46839936bd/Language/ja/Migrations.php#L45-L46