search

codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[sr] Serbian Language translation #373

Closed nebojsajsimic closed 1 year ago

nebojsajsimic commented 1 year ago

Hi i just create Serbian language translation

kenjis commented 1 year ago

Thank you for sending PR!

  1. Please sign your commits. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
  2. The folder should be sr, not rs.
  3. Add test code for sr.
  4. Update MISSING.md and README.md.

See #363 for reference.

nebojsajsimic commented 1 year ago

Thank you for sending PR!

  1. Please sign your commits. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
  2. The folder should be sr, not rs.
  3. Add test code for sr.
  4. Update MISSING.md and README.md.

See #363 for reference.

I think that everything is now fixed :) Cheers!

kenjis commented 1 year ago

Thank you for updates.

Please fix the coding style. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style

And you missed sign one commit 7c1d4c1. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits

kenjis commented 1 year ago

When you set default signing, if you update your branch with git rebase, all commits will be signed. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

kenjis commented 1 year ago

@nebojsajsimic We do not use git merge for PRs. Please use git rebase. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

kenjis commented 1 year ago

ru's coding style is broken now. It is not your fault. See #374