Closed nebojsajsimic closed 1 year ago
Thank you for sending PR!
sr
, not rs
.MISSING.md
and README.md
.See #363 for reference.
Thank you for sending PR!
- Please sign your commits. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
- The folder should be
sr
, notrs
.- Add test code for sr.
- Update
MISSING.md
andREADME.md
.See #363 for reference.
I think that everything is now fixed :) Cheers!
Thank you for updates.
Please fix the coding style. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style
And you missed sign one commit 7c1d4c1. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits
When you set default signing,
if you update your branch with git rebase
, all commits will be signed.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch
@nebojsajsimic We do not use git merge
for PRs.
Please use git rebase
.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch
ru's coding style is broken now. It is not your fault. See #374
Hi i just create Serbian language translation