codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[de] Update HTTP.php #385

Closed sba closed 1 year ago

sba commented 1 year ago

Regarding: https://github.com/codeigniter4/CodeIgniter4/pull/7370

paulbalandan commented 1 year ago

@sba There are new errors:

There were 2 failures:

1) Translations\Tests\GermanTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "de" ('de')
Failed asserting that the language keys "CLI.generator.className.cell", "CLI.generator.fileExist", "CLI.generator.viewName.cell", "Core.invalidDirectory" in the main repository are included for translation in "de" locale.
Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:168
phpvfscomposer:///home/runner/work/translations/translations/vendor/phpunit/phpunit/phpunit:106

2) Translations\Tests\GermanTranslationTest::testAllIncludedLanguageKeysAreConfigured with data set "de" ('de')
Failed asserting that the translated language key "CLI.generator.fileExists" in "de" locale is configured in the main repository.
Failed asserting that an array is empty.
sba commented 1 year ago

I have updated the failing language file: https://github.com/codeigniter4/translations/pull/393

MGatner commented 1 year ago

Errors are unrelated to the change, which we want. @paulbalandan has the last call

paulbalandan commented 1 year ago

Thanks, @sba