Closed mshannaq closed 1 year ago
@paulbalandan the missing updated. Thanks.
Please fix coding style:
1) Language/ar/Files.php (binary_operator_spaces)
---------- begin diff ----------
--- /home/runner/work/translations/translations/Language/ar/Files.php
+++ /home/runner/work/translations/translations/Language/ar/Files.php
@@ -11,8 +11,8 @@
// Files language settings
return [
- 'fileNotFound' => 'الملف غير موجود: {0}',
- 'cannotMove' => 'فشل في نقل الملف من {0} إلى {1} ({2})',
+ 'fileNotFound' => 'الملف غير موجود: {0}',
+ 'cannotMove' => 'فشل في نقل الملف من {0} إلى {1} ({2})',
'expectedDirectory' => '{0} يتوقع وجود مجلد صحيح.',
'expectedFile' => '{0} يتوقع وجود ملف صحيح.',
];
----------- end diff -----------
2) Language/ar/CLI.php (binary_operator_spaces)
---------- begin diff ----------
--- /home/runner/work/translations/translations/Language/ar/CLI.php
+++ /home/runner/work/translations/translations/Language/ar/CLI.php
@@ -15,8 +15,8 @@
'altCommandSingular' => 'هل كنت تقصد هذا ؟',
'commandNotFound' => 'الأمر "{0}" غير موجود.',
'generator' => [
- 'cancelOperation' => 'تم إلغاء العملية.',
- 'className' => [
+ 'cancelOperation' => 'تم إلغاء العملية.',
+ 'className' => [
'cell' => 'اسم كلاس الخلية',
'command' => 'اسم كلاس Command',
'config' => 'اسم كلاس Config',
----------- end diff -----------
3) Language/ar/Router.php (binary_operator_spaces)
---------- begin diff ----------
--- /home/runner/work/translations/translations/Language/ar/Router.php
+++ /home/runner/work/translations/translations/Language/ar/Router.php
@@ -11,8 +11,8 @@
// Router language settings
return [
- 'invalidParameter' => 'المدخلات لا تطابق النوع المتوقع.',
- 'missingDefaultRoute' => 'لا يمكن عرض الصفحة. لم يتم وضع مسار افتراضي للتوجيه له.',
+ 'invalidParameter' => 'المدخلات لا تطابق النوع المتوقع.',
+ 'missingDefaultRoute' => 'لا يمكن عرض الصفحة. لم يتم وضع مسار افتراضي للتوجيه له.',
'invalidDynamicController' => 'لا يُسمح بوجود تحكم دينامكي لأسباب أمان. معالج المسار: "{0}"',
'invalidControllerName' => 'فاصل الفضاء الاسمي namespace هو علامة الشرطة العكسية (\)، وليس شرطة (/). معالج المسار: "{0}"',
];
----------- end diff -----------
https://github.com/codeigniter4/translations/actions/runs/6136121663/job/16658754094?pr=398
@mshannaq run the bin/test
command, and it will fix the coding style.
$ bin/test ar
@mshannaq run the
bin/test
command, and it will fix the coding style.$ bin/test ar
I did it now.
@mshannaq run the
bin/test
command, and it will fix the coding style.$ bin/test ar
Note that running bin/test ar
will not sucess and says:
Fixing coding style...
PHP CS Fixer 3.26.1 Crank Cake by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.2.9
Loaded config CodeIgniter4 Coding Standards from "/home/smartydevenv/ci4-translations/.php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 172 / 925 ( 19%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 344 / 925 ( 37%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 516 / 925 ( 56%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 688 / 925 ( 74%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 860 / 925 ( 93%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 925 / 925 (100%)
Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error
Fixed 0 of 925 files in 0.180 seconds, 14.000 MB memory used
Running test...
vendor/bin/phpunit --filter ArabicTranslationTest --color=always
PHPUnit 9.6.11 by Sebastian Bergmann and contributors.
Runtime: PHP 8.2.9
Configuration: /home/smartydevenv/ci4-translations/phpunit.xml.dist
F...... 7 / 7 (100%)
Time: 00:00.117, Memory: 6.00 MB
There was 1 failure:
1) Translations\Tests\ArabicTranslationTest::testAllConfiguredLanguageFilesAreTranslated with data set "ar" ('ar')
Failed asserting that language file "CLI.php.save" in the main repository is translated in "ar" locale.
Failed asserting that an array is empty.
/home/smartydevenv/ci4-translations/tests/Language/AbstractTranslationTestCase.php:109
FAILURES!
Tests: 7, Assertions: 7, Failures: 1.
until I create a copy from Language/ar/CLI.php and save it as Language/ar/CLI.php.save and then run bin/test ar
@kenjis I think it is fine now , please check , if not I will create another pull request.
I will close this PR and I will request a new PR
@mshannaq Please also add the missing translations. Thanks!