codeigniter4 / translations

System message translations for CodeIgniter4
https://codeigniter4.github.io/translations/
MIT License
197 stars 206 forks source link

[de] Convert windows-1252 files to UTF-8 #399

Closed LeMyst closed 1 year ago

LeMyst commented 1 year ago

Description Some DE files are encoded in "windows-1252" charset instead of UTF-8. I think it's a mistake and after a quick research I didn't find a closed issue about this or any logic why these files are in a different encoding.

Checklist:

paulbalandan commented 1 year ago

Out of scope of this PR.. How can we check if all files are encoded properly? Can we add an auto-review test for that?

kenjis commented 1 year ago

@paulbalandan

$ find Language/de/ -type f -exec file --mime {} \; | grep -v charset=utf-8 | grep -v charset=us-ascii
Language/de//Files.php: text/x-php; charset=iso-8859-1
Language/de//Test.php: text/x-php; charset=iso-8859-1
Language/de//Publisher.php: text/x-php; charset=iso-8859-1
paulbalandan commented 1 year ago

Thank you, @LeMyst