Closed nunhes closed 4 months ago
Thank you for sending this PR!
You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin. See signing. Note that all your commits must be signed. If you have an unsigned commit, you can sign the previous commits by referring to gpg-signing-old-commits.
Thank you for fixing TranslationsCodeTest
.
The four commits are not signed yet. Sign all commits. I recommend you set up git to sign all commits automatically, and squash this branch.
There are missing translations. "CLI.generator.className.test", "Validation.field_exists". Also we cannot merge commits without signing. If you can't sign old commits, please create a new PR.
1) Translations\Tests\GalicianTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "gl" ('gl') Failed asserting that the language keys "CLI.generator.className.test", "Validation.field_exists" in the main repository are included for translation in "gl" locale. Failed asserting that an array is empty.
Hi @nunhes , will you be able to address the test failure?
There was 1 failure:
1) Translations\Tests\GalicianTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "gl" ('gl')
Failed asserting that the language keys "CLI.generator.className.test", "Validation.field_exists" in the main repository are included for translation in "gl" locale.
Failed asserting that an array is empty.
/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:170
Closing for no activity for almost 2 months now.
Description Galician Locale Translation
Checklist: