search

codeine-cd / codeine

Codeine is a continuous deployment tool that makes product deployment faster and safer through automation and monitoring.
Apache License 2.0
28 stars 7 forks source link

Exception thrown when peer not found in DB when running command #173

Closed ezraroi closed 8 years ago

ezraroi commented 8 years ago

The command is canceled as the exception is thrown in the web server. Should return null instead of throwing exception

ezraroi commented 8 years ago

https://github.com/codeine-cd/codeine/commit/8401d9e2513b2d3ad9193b1607650b819e55eae7

oshai commented 8 years ago

A suggestion: return guava Optional instead of returning null. ask @zivry for details.

On Sun, Oct 11, 2015 at 11:45 AM, Roi Ezra notifications@github.com wrote:

8401d9e https://github.com/codeine-cd/codeine/commit/8401d9e2513b2d3ad9193b1607650b819e55eae7

— Reply to this email directly or view it on GitHub https://github.com/codeine-cd/codeine/issues/173#issuecomment-147172632.