search

codeine-cd / codeine

Codeine is a continuous deployment tool that makes product deployment faster and safer through automation and monitoring.
Apache License 2.0
28 stars 7 forks source link

Monitor not sending notification #186

Closed ezraroi closed 8 years ago

ezraroi commented 8 years ago

If the monitor fails on the first time it is running, it will not send notification no matter the mail policy

zivry commented 8 years ago

That was a feature. Tell me, who is code reviewing all this stuff?

On Mon, Jan 25, 2016 at 1:00 PM, Roi Ezra notifications@github.com wrote:

Closed #186 https://github.com/codeine-cd/codeine/issues/186 via 415def4 https://github.com/codeine-cd/codeine/commit/415def412f71ea3f7e0e745a2e808cd080a4d710 .

— Reply to this email directly or view it on GitHub https://github.com/codeine-cd/codeine/issues/186#event-524835173.

ezraroi commented 8 years ago

I hope you will :) Why it was a feature? If i have monitor defined with immediately mail police and it is failing since day one... i will never get an email on it

oshai commented 8 years ago

I am not sure how it was and what you changed, but if you want to get mail on first failure you will get a mail in each codeine peer restart. On Jan 26, 2016 13:12, "Roi Ezra" notifications@github.com wrote:

I hope you will :) Why it was a feature? If i have monitor defined with immediately mail police and it is failing since day one... i will never get an email on it

— Reply to this email directly or view it on GitHub https://github.com/codeine-cd/codeine/issues/186#issuecomment-174959886.

ezraroi commented 8 years ago

We no longer restarts the peers for updating the scripts... no we had monitors failing for day 1 without any notification

oshai commented 8 years ago

ok, are you reading all those mails :-)?

ezraroi commented 8 years ago

I am not, but eyal is using it start for monitoring all the servers so they read them