viewas is not working from statistics page

codeine-cd / codeine

Codeine is a continuous deployment tool that makes product deployment faster and safer through automation and monitoring.

Apache License 2.0

28 stars 7 forks source link

viewas is not working from statistics page #60

Closed oshai closed 10 years ago

oshai commented 10 years ago

Roi, please review my fix, I am sure you will have comments about duplication and angular stuff

ezraroi commented 10 years ago

Yes, I agree. There is a problem with code duplication. I will extract a login service that will tke care of user authentication and the view as

oshai commented 10 years ago

is it possible to have viewas controller? On Oct 19, 2014 7:09 PM, "Roi Ezra" notifications@github.com wrote:

Yes, I agree. There is a problem with code duplication. I will extract a login service that will tke care of user authentication and the view as

— Reply to this email directly or view it on GitHub https://github.com/codeine-cd/codeine/issues/60#issuecomment-59654608.

ezraroi commented 10 years ago

I will look on it later. But anyway, it will be better to manage the logged user in a separate service and not on the root scope.

oshai commented 10 years ago

its not working