search

codeinternetapplications / monolog-stackdriver

Stackdriver handler for Monolog.
MIT License
15 stars 15 forks source link

Change dependency and update docs. #2

Closed IvanOliinychenko closed 5 years ago

IvanOliinychenko commented 5 years ago

Hello, I have a suggestion to change a dependency from "google/cloud": ">=0.50.0" to "google/cloud-logging": "^1.12". It's much liter and brings only what required. Eventually google/cloud uses same dependency internally. Also I updated the docs and included GOOGLE_APPLICATION_CREDENTIALS and GOOGLE_CLOUD_PROJECT global constants. Setting them in $loggingClientOptions is not mandatory, since google/cloud-logging (and google/cloud) hook them up internally. It's more convenient, especially in laravel.

martinatcode commented 5 years ago

Hello Ivan,

Thank you for your submission. I'll take a look at this later this week. Again, thanks!

With kind regards, Martin

petplan-Pat commented 5 years ago

@martinatcode any update about version bumping the core GCP code?

martinatcode commented 5 years ago

Hello Ivan,

I'm sorry. I just merged the branch and might update the documentation since the Google library is able to read from environment variables as well. And if you omit the GOOGLE_CLOUD_PROJECT, it uses the project found in the service account.

With kind regards, Martin